-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(display): Add ability to set display on/off pin. #2814
feat(display): Add ability to set display on/off pin. #2814
Conversation
@@ -62,3 +62,12 @@ See the Devicetree bindings for your display. Here are the bindings for common d | |||
- [SSD1306 (spi)](https://docs.zephyrproject.org/3.5.0/build/dts/api/bindings/display/solomon,ssd1306fb-spi.html) | |||
|
|||
A full list of drivers provided by Zephyr can be found in [Zephyr's Devicetree bindings index](https://docs.zephyrproject.org/3.5.0/build/dts/api/bindings.html). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this is how we normally document these in config pages: https://zmk.dev/docs/config/kscan#devicetree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Missed that. I'll update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caksoylar Tweaked.
Would it not make more sense for |
It does not support more than one. Upstream Zephyr folks are exploring how to more fully integrate it, but there's various pros/cons to a more invasive change, so this is the pragmatic way to support this today, with existing drivers, that won't cause conflicts once upstream settles on an approach. |
Zephyr is still working on the plan upstream for generically controlling display "backlight" pins with GPIO/PWM, so in the meantime, add our own chosen property `zmk,display-led` that is set to an LED device child to allow blanking/unblanking of devices that use a dedicated backlight control pin.
25b8e28
to
68cd0fc
Compare
Zephyr is still working on the plan upstream for generically controlling display "backlight" pins with GPIO/PWM, so in the meantime, add our own chosen property `zmk,display-led` that is set to an LED device child to allow blanking/unblanking of devices that use a dedicated backlight control pin.
Zephyr is still working on the plan upstream for generically controlling display "backlight" pins with GPIO/PWM, so in the meantime, add our own chosen property `zmk,display-led` that is set to an LED device child to allow blanking/unblanking of devices that use a dedicated backlight control pin.
Zephyr is still working on the plan upstream for generically controlling display "backlight" pins with GPIO/PWM, so in the meantime, add our own chosen property
zmk,display-led
that is set to an LED device child to allow blanking/unblanking of devices that use a dedicated backlight control pin.Basically looks like this in the devicetree:
And then you need to enable the
CONFIG_LED=y
Kconfig flag to build that driver subsystem in.PR check-list